[Instrumentation.Process] Cleanup public APIs. #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
reviewed
Feb 6, 2023
| /// </summary> | ||
| /// <param name="builder"><see cref="MeterProviderBuilder"/> being configured.</param> | ||
| /// <param name="configure">Runtime metrics options.</param> | ||
| /// <param name="configure">Process metrics options.</param> |
There was a problem hiding this comment.
this method can be removed for now as there is nothing to configure in ProcessInstrumentaionOptions
There was a problem hiding this comment.
The option class seems to be also not needed.
There was a problem hiding this comment.
okay to leave it empty or keep internal. I think it was put as placeholder.
There was a problem hiding this comment.
updated to use internal
cijothomas
previously approved these changes
Feb 6, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
==========================================
- Coverage 68.37% 68.34% -0.03%
==========================================
Files 183 183
Lines 7026 7023 -3
==========================================
- Hits 4804 4800 -4
- Misses 2222 2223 +1
|
|
Please update changelog. It might be breaking change for part of the users. |
cijothomas
dismissed
their stale review
need changelog update as this PR is no longer a nit comment fix
Kielek
changed the title
Yun-Ting
changed the title
cijothomas
reviewed
Feb 7, 2023
cijothomas
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Cleanup public APIs.
CHANGELOG.mdupdated for non-trivial changes