[Instrumentation.Process] Removed CPU utilization metric process.cpu.utilization.
#972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #972 +/- ##
==========================================
- Coverage 68.34% 68.24% -0.11%
==========================================
Files 183 183
Lines 7023 7010 -13
==========================================
- Hits 4800 4784 -16
- Misses 2223 2226 +3
|
Kielek
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
It is part of experimental ote-spec
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/process-metrics.md
it will be good to eventually bring it back.
cijothomas
reviewed
Feb 7, 2023
alanwest
approved these changes
Feb 7, 2023
Yun-Ting
changed the title
process.cpu.utilization.
cijothomas
approved these changes
Feb 8, 2023
|
@Yun-Ting Could you fix the conflicts, and we are good to merge |
reyang
approved these changes
Feb 8, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #831.
Related to: #948
Changes
Used static ctor for ProcessMetrics and made Meter static.
Removed/updated CPU utilization related tests.
Added tests to check thread safety.
CHANGELOG.mdupdated for non-trivial changes