-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exporter.Geneva] Add TLDLogExporter #874
[Exporter.Geneva] Add TLDLogExporter #874
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #874 +/- ##
==========================================
- Coverage 70.01% 68.87% -1.14%
==========================================
Files 187 188 +1
Lines 6826 7081 +255
==========================================
+ Hits 4779 4877 +98
- Misses 2047 2204 +157
|
@@ -27,6 +27,7 @@ | |||
using System.Threading.Tasks; | |||
using Microsoft.Extensions.Logging; | |||
using OpenTelemetry.Logs; | |||
using OpenTelemetry.Trace; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this (trace) needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not needed. I have removed it.
Changes
TODOs:
ThreadLocal
instead of multipleList<KeyValuePair<string, object>> keyValuePairs
Setup and usage:
You could us any ETW collection tools such as WPA, PerfView etc. to view the data:
Example with PerfView:
For the connectionString =
"EtwSession=OpenTelemetry;PrivatePreviewEnableTraceLoggingDynamic=true"
, you can run the following command in Command Prompt: