Updated MassTransit instrumentation to OpenTelemetry 1.0

[alexvaluyskiy]

This PR upgrades the MassTransit instrumentation to OTel version 1.0.2

[alexvaluyskiy]

One test, related to trace filtering is failing (I will investigate why). But the rest of the PR is ready to review

[cijothomas]

Looks good from the perspective of removing ActivitySourceAdapter and leveraging AddLegacySource feature.

Not MT expert to offer deeper review :)

[codecov]

Codecov Report

Merging #85 (21e1739) into main (8323c83) will decrease coverage by 0.02%.
The diff coverage is 80.48%.

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   77.55%   77.52%   -0.03%     
==========================================
  Files          51       52       +1     
  Lines        1430     1455      +25     
==========================================
+ Hits         1109     1128      +19     
- Misses        321      327       +6     

Impacted Files	Coverage Δ
...mentation/MassTransitInstrumentationEventSource.cs	37.50% <37.50%> (ø)
...it/Implementation/MassTransitDiagnosticListener.cs	93.97% <85.71%> (-3.25%)	⬇️
...entation.MassTransit/MassTransitInstrumentation.cs	100.00% <100.00%> (+22.22%)	⬆️
...ion.MassTransit/TracerProviderBuilderExtensions.cs	90.90% <100.00%> (+10.90%)	⬆️

[alexvaluyskiy]

@cijothomas any blockers for this PR?

[cijothomas]

@cijothomas any blockers for this PR?

Would you update codeowners file to list yourself as an approver for the MassTransit instrumentation? Similar to this https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/CODEOWNERS#L12

[alexvaluyskiy]

@cijothomas done

[cijothomas]

nit: RequestIsFilteredOut doesn't sound the apt name here.

[cijothomas]

nit: This error message seem to indicate an error occuring in some user defined Enrich function. Given this is an internal transformation error, please rename the method and log message accordingly.

[cijothomas]

Left some non-blocking comments, please try to address them in a future PR.
Also it'd be good to get a changelog.md file initiated for this project.

[alexvaluyskiy]

@cijothomas thank you. I will fix remaining comments in the next pull requests.
What actions should be performed to release this instrumentation to nuget?

[cijothomas]

@alexvaluyskiy The release is manual, and one of the maintainers have to do it now.
@srprash Did you get a chance to document the process for releasing from this repo?

(@CodeBlanch did a manual release for wcf last week, but we need to list the process and (then automate))

[alexvaluyskiy]

But I think, we have to wait for OpenTelemetry 1.0.2 release first

[cijothomas]

But I think, we have to wait for OpenTelemetry 1.0.2 release first

yea. we'll likely name it (OpenTelemetry .SDK)1.1.0-beta1 before pushing to nuget.org.

[CodeBlanch]

The release process I used for WCF...

Setup

• Pick your favorite workflow from .github/workflows and copy/rename for your project. Update the workflow name, project name, and tag prefix. I wish we didn't have to copy/paste like this, but I looked around and github workflows don't support templates yet (from what I could tell).

• In your csproj add <MinVerTagPrefix>Instrumentation.Wcf-</MinVerTagPrefix> except with the tag prefix you picked. The tag prefix here needs to match what's in the workflow (minus wildcard).

Release

• Push a tag to opentelemetry-dotnet-contrib using the tag prefix you selected and the version you want to release. It is a good idea to check with @cijothomas for the version to use because if you make a mistake you have to unlist the package and we can never use that version again.

  $ git tag -a Instrumentation.Wcf-1.0.0-rc1 -m Instrumentation.Wcf-1.0.0-rc1
  $ git push origin Instrumentation.Wcf-1.0.0-rc1

  I usually work on a fork of opentelemetry-dotnet-contrib but I ran those commands directly against a clone of the main repo. I'm sure there is a way to add tag on the fork origin and push to upstream, but I'm kind of git CLI newb so I went this route.

• The tag should kick off an automatic run of the workflow you configured. Check the "Actions" tab on GitHub. Wait for it to complete.

• The output of the workflow will be attached automatically to the run. Download it right from the GitHub UI.

• Upload the .nupkg and .snupkg from the downloaded zip to NuGet. For me NuGet automatically populated everything correctly. You need to have access on NuGet to do this.

[cijothomas]

thanks @CodeBlanch
@srprash Please take a look at the steps Mikel followed above, when you writing releasing doc. This is missing the Github release, so we need to add that too.