[Exporter.Geneva] Fix overflow bucket value serialization for Histogram #805
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
added
the
comp:exporter.geneva
github-actions
bot
assigned cijothomas, CodeBlanch, mic-max, reyang, utpilla and Yun-Ting
github-actions
bot
requested review from
cijothomas,
CodeBlanch,
mic-max,
reyang and
Yun-Ting
utpilla
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
=======================================
Coverage 77.97% 77.97%
=======================================
Files 176 176
Lines 5313 5313
=======================================
Hits 4143 4143
Misses 1170 1170
|
Kielek
approved these changes
Dec 7, 2022
CodeBlanch
reviewed
Dec 7, 2022
| @@ -780,6 +779,8 @@ private void CheckSerializationForSingleMetricPoint(Metric metric, GenevaMetricE | |||
| listIterator++; | |||
| bucketsWithPositiveCount++; | |||
| } | |||
|
|
|||
| lastExplicitBound = bucket.ExplicitBound; | |||
There was a problem hiding this comment.
Something about this test design seems off. I was expecting to see a test case being added in the spirit of: "Given buckets x, y, & z expect last bucket to be z + 1." Maybe it is too dynamic for its own good? 😄
Anyway doesn't need to be fixed as part of this, just musing.
There was a problem hiding this comment.
Haha you're right! It was too dynamic to even catch that issue in the first place 😀
I'll work on fixing this later.
1 task
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The values for overflow buckets should be serialized as the value-count pair: LastBucketValue + 1,count
For eg. for a Histogram with the boundaries: [25,50,100], if the value recorded is 150, it should be serialized as the following value-count pair: (101, 1)
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes