Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package workflow for runtime #793

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Nov 23, 2022

Package publish workflow is failing for this project: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/3528050002/jobs/5917735748

Changes

  • Setup .NET 7

@utpilla utpilla added the comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime label Nov 23, 2022
@utpilla utpilla requested a review from a team November 23, 2022 01:33
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #793 (b3fb5c0) into main (108843c) will increase coverage by 0.39%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
+ Coverage   77.59%   77.99%   +0.39%     
==========================================
  Files         176      176              
  Lines        5312     5312              
==========================================
+ Hits         4122     4143      +21     
+ Misses       1190     1169      -21     
Impacted Files Coverage Δ
...elemetry.Instrumentation.Runtime/RuntimeMetrics.cs 100.00% <0.00%> (+14.38%) ⬆️

@Kielek
Copy link
Contributor

Kielek commented Nov 23, 2022

Changes looks good, but we need also install net core 3.1 for (ubuntu-latest, netcoreapp3.1). The alternative way is to drop it completely.

@utpilla utpilla merged commit 74cda61 into open-telemetry:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants