Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prerelease reference and bump OTel to 1.4.0-beta.3 #774

Merged
merged 6 commits into from
Nov 17, 2022

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Nov 17, 2022

Fixes N/A

I am working on update .NET AutoInstrumentation to 1.4.0-beta.3.
In one project we reference a lot of projects, but 2 are relevant.

    <PackageReference Include="OpenTelemetry.Api" Version="1.4.0-beta.3" />
    <PackageReference Include="OpenTelemetry.Instrumentation.Process" Version="1.0.0-alpha.1" />

It leads to

Severity	Code	Description	Project	File	Line	Suppression State
Error	NU1608	Detected package version outside of dependency constraint: OpenTelemetry.Instrumentation.Process 1.0.0-alpha.1 requires OpenTelemetry.Api (= 1.4.0-beta.2) but version OpenTelemetry.Api 1.4.0-beta.3 was resolved.	OpenTelemetry.AutoInstrumentation	C:\GitHub\opentelemetry-dotnet-instrumentation\src\OpenTelemetry.AutoInstrumentation\OpenTelemetry.AutoInstrumentation.csproj	1	

Changes

Allow to use higher version than the specified in the props file.
Bump OTel to 1.4.0-beta.3.

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #

@Kielek Kielek marked this pull request as ready for review November 17, 2022 12:41
@Kielek Kielek requested a review from a team November 17, 2022 12:41
@Kielek Kielek marked this pull request as draft November 17, 2022 12:53
build/Common.props Outdated Show resolved Hide resolved
@Kielek Kielek marked this pull request as ready for review November 17, 2022 13:21
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #774 (1a0377f) into main (23dbc39) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #774   +/-   ##
=======================================
  Coverage   77.59%   77.59%           
=======================================
  Files         176      176           
  Lines        5312     5312           
=======================================
  Hits         4122     4122           
  Misses       1190     1190           
Impacted Files Coverage Δ
...ry.Exporter.Geneva/Metrics/GenevaMetricExporter.cs 58.09% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants