Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instrumentation.Process] Update .NET API for virtual memory usage #762

Merged
merged 9 commits into from
Nov 12, 2022
Merged

[Instrumentation.Process] Update .NET API for virtual memory usage #762

merged 9 commits into from
Nov 12, 2022

Conversation

Yun-Ting
Copy link
Contributor

@Yun-Ting Yun-Ting commented Nov 8, 2022

@Yun-Ting Yun-Ting marked this pull request as ready for review November 8, 2022 22:33
@Yun-Ting Yun-Ting requested a review from a team November 8, 2022 22:33
@codecov
Copy link

codecov bot commented Nov 8, 2022 •
edited
Loading

Codecov Report

Merging #762 (fb4f478) into main (edae331) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #762   +/-   ##
=======================================
  Coverage   77.56%   77.56%           
=======================================
  Files         176      176           
  Lines        5308     5308           
=======================================
  Hits         4117     4117           
  Misses       1191     1191
Impacted Files Coverage Δ
...elemetry.Instrumentation.Process/ProcessMetrics.cs 100.00% <100.00%> (ø)

@utpilla utpilla added the comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process label Nov 9, 2022
@Kielek
Copy link
Contributor

Kielek commented Nov 9, 2022

@Yun-Ting, could you please update changelog and readme (if needed)?

noahfalk
noahfalk reviewed Nov 10, 2022
View reviewed changes
Copy link
Contributor

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad we are making this change 👍

src/OpenTelemetry.Instrumentation.Process/ProcessMetrics.cs Outdated Show resolved Hide resolved
src/OpenTelemetry.Instrumentation.Process/README.md Outdated Show resolved Hide resolved
CodeBlanch
CodeBlanch approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit cceb2fc into open-telemetry:main Nov 12, 2022
@Yun-Ting Yun-Ting deleted the yunl/virtualMem branch November 14, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahfalk noahfalk noahfalk left review comments

@utpilla utpilla utpilla approved these changes

@CodeBlanch CodeBlanch CodeBlanch approved these changes

Assignees

@Yun-Ting Yun-Ting

Labels
comp:instrumentation.process Things related to OpenTelemetry.Instrumentation.Process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yun-Ting @Kielek @noahfalk @CodeBlanch @utpilla