Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instrumentation.Hangfire] Enable Public API analyzer #734

Merged
merged 5 commits into from
Oct 26, 2022
Merged

[Instrumentation.Hangfire] Enable Public API analyzer #734

merged 5 commits into from
Oct 26, 2022

Conversation

vitor-pinto-maersk
Copy link
Contributor

Fixes open-telemetry/opentelemetry-specification#725

Changes

Adds Public API Analyzer.

@vitor-pinto-maersk vitor-pinto-maersk requested a review from a team October 26, 2022 09:54
@codecov
Copy link

codecov bot commented Oct 26, 2022 •
edited
Loading

Codecov Report

Merging #734 (9e771be) into main (8f7fbd4) will not change coverage.
The diff coverage is n/a.

❗ Current head 9e771be differs from pull request most recent head 3dcc2ba. Consider uploading reports for the commit 3dcc2ba to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     open-telemetry/opentelemetry-specification#734   +/-   ##
=======================================
  Coverage   77.55%   77.55%           
=======================================
  Files         176      176           
  Lines        5298     5298           
=======================================
  Hits         4109     4109           
  Misses       1189     1189

@cijothomas cijothomas merged commit 6a2545f into open-telemetry:main Oct 26, 2022
@vitor-pinto-maersk vitor-pinto-maersk deleted the task/hangfire-public-api-analyzers branch October 26, 2022 16:53
@cijothomas
Copy link
Member

https://www.nuget.org/packages/OpenTelemetry.Instrumentation.Hangfire/1.0.0-beta.3 published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kielek Kielek Kielek approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Delta" sums for UpDownCounter are error prone
3 participants
@vitor-pinto-maersk @cijothomas @Kielek