Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project name for test step #73

Merged
merged 2 commits into from
Feb 22, 2021

Conversation

srprash
Copy link
Contributor

@srprash srprash commented Feb 21, 2021

I missed to notice that the tests for the projects have .Tests suffixed to them and isn't the exact name as their source projects. So this PR aims to fix the test step in the workflows by explicitly calling the test projects rather than using the PROJECT variable.
I could have generalized this too but for some reason the EntityFrameworkCore project doesn't exactly follow the .Tests convention rather has the Tests suffix. Maybe we can fix it later for the sake of consistency in the repo.

@srprash srprash requested a review from a team February 21, 2021 21:55
@codecov
Copy link

codecov bot commented Feb 21, 2021

Codecov Report

Merging #73 (3ccc7f8) into main (dcc8a3b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   70.95%   70.95%           
=======================================
  Files          28       28           
  Lines         809      809           
=======================================
  Hits          574      574           
  Misses        235      235           

@srprash srprash changed the title Use complete project name for test step Fix project name for test step Feb 21, 2021
@cijothomas cijothomas merged commit 810b052 into open-telemetry:main Feb 22, 2021
srprash added a commit that referenced this pull request Feb 23, 2021
Sorry I missed this one before merging in the whole PR. Doing the same fix as done for the rest of the workflows in #73
srprash added a commit that referenced this pull request Feb 23, 2021
Sorry I missed this one before merging in the whole PR. Doing the same fix as done for the rest of the workflows in #73
CodeBlanch added a commit to CodeBlanch/opentelemetry-dotnet-contrib that referenced this pull request Feb 25, 2021
SergeyKanzhelev pushed a commit that referenced this pull request Mar 5, 2021
* WCF instrumentation + example apps.

* Added an event source to log errors in Wcf instrumentation.

* Added content to the WCF instrumentation's README.

* Added support for the .NET Core version of WCF clients.

* Code review feedback.

* Updated code for 1.0 and changes done in main.

* Lint errors.

* Server tests and cleanup.

* Added client tests.

* Fixed some weirdness with SuppressDownstreamInstrumentation.

* Bug fixes.

* Attempting to fix lint errors.

* Code review and clean up.

* Added "wcf-" MinVerTagPrefix in csproj.

* Fun with copy-paste.

* Removed OpenTelemetry.Instrumentation.Http from wcf client examples.

* Updated link paths.

* Code review.

* Added wcf examples readme.

* Code review.

* Typo.

* Markdown lint.

* Code review.

* Code review.

* Code review.

* Code review.

* Add support for To & Via properties.

* Code review.

* Code review.

* Example readme update.

* Mirror fix from PR #73.

* Nits.

* Hashtable for cache.

* Code review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants