-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix project name for test step #73
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage 70.95% 70.95%
=======================================
Files 28 28
Lines 809 809
=======================================
Hits 574 574
Misses 235 235 |
eddynaka
reviewed
Feb 21, 2021
eddynaka
approved these changes
Feb 21, 2021
cijothomas
approved these changes
Feb 22, 2021
srprash
added a commit
that referenced
this pull request
Feb 23, 2021
Sorry I missed this one before merging in the whole PR. Doing the same fix as done for the rest of the workflows in #73
srprash
added a commit
that referenced
this pull request
Feb 23, 2021
Sorry I missed this one before merging in the whole PR. Doing the same fix as done for the rest of the workflows in #73
CodeBlanch
added a commit
to CodeBlanch/opentelemetry-dotnet-contrib
that referenced
this pull request
Feb 25, 2021
SergeyKanzhelev
pushed a commit
that referenced
this pull request
Mar 5, 2021
* WCF instrumentation + example apps. * Added an event source to log errors in Wcf instrumentation. * Added content to the WCF instrumentation's README. * Added support for the .NET Core version of WCF clients. * Code review feedback. * Updated code for 1.0 and changes done in main. * Lint errors. * Server tests and cleanup. * Added client tests. * Fixed some weirdness with SuppressDownstreamInstrumentation. * Bug fixes. * Attempting to fix lint errors. * Code review and clean up. * Added "wcf-" MinVerTagPrefix in csproj. * Fun with copy-paste. * Removed OpenTelemetry.Instrumentation.Http from wcf client examples. * Updated link paths. * Code review. * Added wcf examples readme. * Code review. * Typo. * Markdown lint. * Code review. * Code review. * Code review. * Code review. * Add support for To & Via properties. * Code review. * Code review. * Example readme update. * Mirror fix from PR #73. * Nits. * Hashtable for cache. * Code review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed to notice that the tests for the projects have
.Tests
suffixed to them and isn't the exact name as their source projects. So this PR aims to fix the test step in the workflows by explicitly calling the test projects rather than using thePROJECT
variable.I could have generalized this too but for some reason the EntityFrameworkCore project doesn't exactly follow the
.Tests
convention rather has theTests
suffix. Maybe we can fix it later for the sake of consistency in the repo.