Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.Hangfire] Update CHANGELOG for 1.0.0 release #728

Merged
merged 5 commits into from
Oct 24, 2022

Conversation

fred2u
Copy link
Contributor

@fred2u fred2u commented Oct 23, 2022

Changes

Update CHANGELOG for 1.0.0 release

@fred2u fred2u requested a review from a team October 23, 2022 12:39
@Kielek Kielek added the comp:instrumentation.hangfire Things related to OpenTelemetry.Instrumentation.Hangfire label Oct 24, 2022
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-telemetry/dotnet-contrib-maintainers, could you please check release request?

src/OpenTelemetry.Instrumentation.Hangfire/CHANGELOG.md Outdated Show resolved Hide resolved
@utpilla utpilla merged commit 6158fdb into open-telemetry:main Oct 24, 2022
@@ -2,6 +2,10 @@

## Unreleased

## 1.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you relying on any semantic conventions from otel? if yes, we'll need to hold off from 1.0.0 stable. If not, we need to document the attribute/tag names in the readme, before stable release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cijothomas No, I'm not

@fred2u fred2u deleted the release/1.0.0 branch May 23, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.hangfire Things related to OpenTelemetry.Instrumentation.Hangfire
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants