-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.Hangfire] Add option to record exceptions #719
[Instrumentation.Hangfire] Add option to record exceptions #719
Conversation
...lemetry.Instrumentation.Hangfire/Implementation/HangfireInstrumentationJobFilterAttribute.cs
Outdated
Show resolved
Hide resolved
...enTelemetry.Instrumentation.Hangfire.Tests/HangfireInstrumentationJobFilterAttributeTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Changes looks good to me.
Please also add changelog entry
@fred2u Could you review? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
==========================================
- Coverage 77.70% 77.65% -0.05%
==========================================
Files 175 176 +1
Lines 5333 5335 +2
==========================================
- Hits 4144 4143 -1
- Misses 1189 1192 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider enabling public API analyzer as well. This could be done in a follow-up PR.
Changes
Adds support to optionally record hangfire job exceptions.