[Exporter.Geneva] Add support for UpDownCounter and ObservableUpDownCounter #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
added
the
comp:exporter.geneva
github-actions
bot
assigned cijothomas, CodeBlanch, mic-max, reyang, utpilla and Yun-Ting
github-actions
bot
requested review from
cijothomas,
CodeBlanch,
mic-max,
reyang and
Yun-Ting
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #685 +/- ##
==========================================
+ Coverage 77.60% 77.70% +0.09%
==========================================
Files 175 175
Lines 5323 5333 +10
==========================================
+ Hits 4131 4144 +13
+ Misses 1192 1189 -3
|
mic-max
approved these changes
Oct 13, 2022
Kielek
approved these changes
Oct 13, 2022
cijothomas
reviewed
Oct 13, 2022
src/OpenTelemetry.Exporter.Geneva/Metrics/GenevaMetricExporter.cs
Outdated
Show resolved
Hide resolved
cijothomas
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/685/files#r994145083
Need to confirm how to deal with negative values.
cijothomas
suggested changes
Oct 13, 2022
cijothomas
reviewed
Oct 20, 2022
src/OpenTelemetry.Exporter.Geneva/Metrics/GenevaMetricExporter.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Cijo Thomas <[email protected]>
cijothomas
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes