-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.Runtime] Update OTel API version to 1.4.0-beta.2
and change runtime metrics type to ObservableUpDownCounter
#675
[Instrumentation.Runtime] Update OTel API version to 1.4.0-beta.2
and change runtime metrics type to ObservableUpDownCounter
#675
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #675 +/- ##
=======================================
Coverage 77.74% 77.74%
=======================================
Files 176 176
Lines 5343 5343
=======================================
Hits 4154 4154
Misses 1189 1189
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have doubts if the beta version should be included into the contrib.
The changes does not looks huge and probably could be included together with 1.4.0 release.
Co-authored-by: Piotr Kiełkowicz <[email protected]>
I have similar doubts on how to integrate beta version. If there happen to be any changes needed for the stable version, we'd need to create a branch from a past commit and maintain two branches. However, there are some benefits for doing it early:
@utpilla Do you have any suggestion? Especially for removing |
Each component can chose the version they want. We have no reason to prevent any component from moving to a newer version. |
@@ -90,8 +89,7 @@ static RuntimeMetrics() | |||
// Either Environment.Version is not 6 or (it's 6 but internal API GC.GetGenerationSize is valid) | |||
if (!isCodeRunningOnBuggyRuntimeVersion || getGenerationSize != null) | |||
{ | |||
// TODO: change to ObservableUpDownCounter | |||
MeterInstance.CreateObservableGauge( | |||
MeterInstance.CreateObservableUpDownCounter( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think this is a breaking change? For sure OTLP Exporters see dif. data type now, but exporter like Prometheus would be fine...
@alanwest Can you check from NR stand point, if this will be breaking for anyone sending to NR via OTLP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for delay. No this is not breaking for New Relic. NR has its own gauge data type. Both OTLP gauges and OTLP non-monotonic sums are transformed to a NR gauge, so there will be no difference for end users querying this data in NR.
Though, it may be possible this could be breaking for other backends.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can bring this to the next SIG to make a call about do we need to major version bump or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lachmatt checked changes with Splunk OTLP endpoint and it is working correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW I would consider it as a bugfix not a breaking change. There were no possibility to set it correctly with older dependencies.
1.4.0-beta.1
and change runtime metrics type to ObservableUpDownCounter1.4.0-beta.1
and change runtime metrics type to ObservableUpDownCounter
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
1.4.0-beta.1
and change runtime metrics type to ObservableUpDownCounter1.4.0-beta.2
and change runtime metrics type to ObservableUpDownCounter
@@ -301,6 +297,23 @@ metric is available in the .NET version you are running. | |||
Some GC related metrics are unavailable until at least one garbage collection | |||
has occurred. | |||
|
|||
## Note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look good!
Based on most comments I am proposing to release this as minor version bump only. But will discuss this in next SIG meeting to finalize. (Stable cannot anyway occur before 1.4.0 of the API itself is stable, expected November 2022)
Update OTel API version to
1.4.0-beta.2
and change runtime metrics type to ObservableUpDownCounter now that it's ready. (Released in 1.4.0-beta.1: https://github.com/open-telemetry/opentelemetry-dotnet/releases/tag/core-1.4.0-beta.1)For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes