Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.Geneva] Refactor GenevaExporter #649

Merged
merged 10 commits into from
Sep 27, 2022

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Sep 19, 2022

Changes

  • Refactor GenevaTraceExporter and GenevaLogExporter to make their behavior configurable in the ctor
  • This would allow us switch from MsgPack to TLD later on
  • Moved the classes with extension methods outside of the MsgPackExporter folder

@utpilla utpilla added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Sep 19, 2022
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #649 (b400805) into main (58cf8d7) will decrease coverage by 0.03%.
The diff coverage is 76.81%.

❗ Current head b400805 differs from pull request most recent head b95b643. Consider uploading reports for the commit b95b643 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
- Coverage   77.78%   77.74%   -0.04%     
==========================================
  Files         171      173       +2     
  Lines        5158     5191      +33     
==========================================
+ Hits         4012     4036      +24     
- Misses       1146     1155       +9     
Impacted Files Coverage Δ
....Exporter.Geneva/GenevaExporterHelperExtensions.cs 58.33% <ø> (ø)
...lemetry.Exporter.Geneva/GenevaLoggingExtensions.cs 85.71% <ø> (ø)
...ter.Geneva/MsgPackExporter/MsgPackTraceExporter.cs 92.89% <69.23%> (ø)
...orter.Geneva/MsgPackExporter/MsgPackLogExporter.cs 93.75% <75.00%> (ø)
...OpenTelemetry.Exporter.Geneva/GenevaLogExporter.cs 80.00% <80.00%> (ø)
...enTelemetry.Exporter.Geneva/GenevaTraceExporter.cs 80.00% <80.00%> (ø)
...er.Geneva/MsgPackExporter/MessagePackSerializer.cs 92.27% <0.00%> (-0.49%) ⬇️

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@utpilla utpilla merged commit 7f8df02 into open-telemetry:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants