-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exporter.Geneva] Refactor GenevaExporter #649
Merged
utpilla
merged 10 commits into
open-telemetry:main
from
utpilla:utpilla/Refactor-GenevaExporter
Sep 27, 2022
Merged
[Exporter.Geneva] Refactor GenevaExporter #649
utpilla
merged 10 commits into
open-telemetry:main
from
utpilla:utpilla/Refactor-GenevaExporter
Sep 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned cijothomas, CodeBlanch, mic-max, reyang, utpilla and Yun-Ting
Sep 19, 2022
github-actions
bot
requested review from
cijothomas,
CodeBlanch,
mic-max,
reyang and
Yun-Ting
September 19, 2022 23:28
utpilla
added
the
comp:exporter.geneva
Things related to OpenTelemetry.Exporter.Geneva
label
Sep 19, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
==========================================
- Coverage 77.78% 77.74% -0.04%
==========================================
Files 171 173 +2
Lines 5158 5191 +33
==========================================
+ Hits 4012 4036 +24
- Misses 1146 1155 +9
|
reyang
reviewed
Sep 26, 2022
reyang
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
cijothomas
reviewed
Sep 26, 2022
cijothomas
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
MsgPackExporter
folder