-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrumentation.AwsLambda: Fix versioning scheme. #639
Instrumentation.AwsLambda: Fix versioning scheme. #639
Conversation
|
||
This is the first release with the new package name `OpenTelemetry.Instrumentation.AWSLambda`. | ||
|
||
* BREAKING (API, behavior): Rename package to `OpenTelemetry.Instrumentation.AWSLambda` | ||
(remove `.Contrib`) ([#593](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/593)). | ||
This also affects the `ActivitySource` name (superseding [#534](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/534)). | ||
* Pre-release version numbering scheme changed from `.betaN` to `beta.N` ([#639](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/639)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed this does not require a change in the unit tests since we use the Assembly version which has a fixed format of four integers. IMHO this is wrong and we should use the assembly product version instead. But consistency between different packages is at least as important, so this should be discussed in general, not just for this package.
@@ -2,15 +2,17 @@ | |||
|
|||
## Unreleased | |||
|
|||
## 1.1.0-beta2 | |||
## 1.1.0-beta.2 | |||
|
|||
Release PR: [#590](https://github.com/open-telemetry/opentelemetry-dotnet-contrib/pull/590) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We don't need an entry for Release PR.
Fixes #590 (comment), CC @utpilla
Changes
Changes version numbering scheme of the Instrumentation.AwsLambda which was previously released as 1.1.0.beta1 (& different package name) to use a dot before the pre-release number.