Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Individual component versioning through tag prefixes #63

Merged
merged 4 commits into from
Feb 5, 2021

Conversation

srprash
Copy link
Contributor

@srprash srprash commented Feb 5, 2021

MinVer provides a feature to version multiple projects in a single repo independently by defining a tag prefix for each project. I believe we can leverage this feature by defining specific tag prefix for each project and then creating a tag with <projectPrefix>-<version> when we want to do a release for the project.

For example, if the project name is OpenTelemetry.Contrib.Extensions.AWSXRay, the tag prefix will be Extensions.AWSXRay- and the tag name will be Extensions.AWSXRay-1.0.0-rc2.

Any new project added to the repo must define the <MinVerTagPrefix> in its csproj file.

I checked the naming requirements for a git tag name but didn't find a restriction on the length. Please call out here if you know of any such limit.

@srprash srprash requested a review from a team February 5, 2021 16:05
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #63 (12ccd44) into main (a7e698f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   70.95%   70.95%           
=======================================
  Files          28       28           
  Lines         809      809           
=======================================
  Hits          574      574           
  Misses        235      235           

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! this is the same approach used in the sdk repo as well. So far it works well. :)

@cijothomas cijothomas merged commit 736e6c0 into open-telemetry:main Feb 5, 2021
@srprash srprash deleted the separate_versioning branch February 5, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants