Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.EventCounters] Stabilize and Enable Testing #620

Merged
merged 36 commits into from
Oct 13, 2022
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
57986a6
wip
mic-max Sep 1, 2022
51d9cce
nit
mic-max Sep 1, 2022
59e4faa
Rename options class
mic-max Sep 1, 2022
2e2af13
skip failing test
mic-max Sep 1, 2022
8fbb353
fix build error
mic-max Sep 1, 2022
e13c37f
whitespacing
mic-max Sep 1, 2022
3eb1061
Update EventCounterListenerTests.cs
mic-max Sep 6, 2022
97ed727
Add changelog, owner
mic-max Sep 6, 2022
732bc59
clean
mic-max Sep 6, 2022
a1566d1
readme fixup
mic-max Sep 6, 2022
1f5b50e
Merge branch 'main' into eventcounters-stabilize
mic-max Sep 6, 2022
60938d3
use same naming scheme as other instrumentations
mic-max Sep 6, 2022
adca7c5
Merge branch 'eventcounters-stabilize' of https://github.com/mic-max/…
mic-max Sep 6, 2022
37414ca
Update MeterProviderBuilderExtensions.cs
mic-max Sep 7, 2022
1a0c496
Set default polling time to 1 second
mic-max Sep 13, 2022
906b84c
Update README.md
mic-max Sep 13, 2022
d5c7fdf
AddCounters and ShouldListenTo methods
mic-max Sep 13, 2022
8d0a30e
Rename EventCountersMetricsTests file
mic-max Sep 14, 2022
c8af401
Update EventCountersMetricsTests.cs
mic-max Sep 14, 2022
99097fc
Update EventCountersMetrics.cs
mic-max Sep 14, 2022
78d981d
Throw error when registering multiple times
mic-max Sep 14, 2022
f73858b
Revert "Throw error when registering multiple times"
mic-max Sep 14, 2022
b44f952
privify EnableEventsArguments
mic-max Sep 22, 2022
1ef006e
Merge branch 'main' into eventcounters-stabilize
mic-max Sep 22, 2022
12cbb30
pr comments
mic-max Sep 22, 2022
ecaeea4
Merge branch 'eventcounters-stabilize' of https://github.com/mic-max/…
mic-max Sep 22, 2022
9398617
tada
mic-max Sep 28, 2022
e558609
Update EventCountersInstrumentationOptions.cs
mic-max Sep 28, 2022
72e52d1
exception tests
mic-max Sep 29, 2022
54d8b2c
fixing recommendations
mic-max Oct 5, 2022
6daa63d
cleanup
mic-max Oct 6, 2022
553ae87
fix
mic-max Oct 6, 2022
556b65e
CI rerun
mic-max Oct 10, 2022
71560ed
remove duplicate checks sdk already does
mic-max Oct 13, 2022
65521ee
Merge branch 'main' into eventcounters-stabilize
utpilla Oct 13, 2022
a6bfef2
Merge branch 'main' into eventcounters-stabilize
utpilla Oct 13, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix build error
mic-max committed Sep 1, 2022
commit 8fbb35389eab9aa7ebf1e3832954cc678099b47f
Original file line number Diff line number Diff line change
@@ -41,7 +41,7 @@ public static MeterProviderBuilder AddEventCounterListener(
configure?.Invoke(options);

var instrumentation = new EventCounterListener(options);
builder.AddMeter(options.MeterName);
builder.AddMeter(EventCounterListener.MeterInstance.Name);
return builder.AddInstrumentation(() => instrumentation);
}
}