[Instrumentation.AwsLambda] Rename Trace to TraceAsync where appropriate #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
force-pushed
the
feature/awslambda-traceasync
branch
from
5dd1980 to
d684283
Compare
Oberon00
force-pushed
the
feature/awslambda-traceasync
branch
from
d684283 to
216ea99
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
=======================================
Coverage 76.70% 76.70%
=======================================
Files 170 170
Lines 5161 5161
=======================================
Hits 3959 3959
Misses 1202 1202
|
utpilla
added
the
comp:instrumentation.aws
Oberon00
commented
Aug 25, 2022
| @@ -89,80 +89,80 @@ public class AWSLambdaWrapper | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Tracing wrapper for async Lambda handler. | |||
| /// Tracing wrapper for Lambda handler. | |||
There was a problem hiding this comment.
Please look at the commits in the diff separately, I had to move a function around and that causes to the diffing algorithm to go off the rails apparently.
|
@rypdal Could you please review this PR? |
utpilla
added
comp:instrumentation.awslambda
|
@rypdal Will probably not be available before Thursday. |
rypdal
approved these changes
Sep 1, 2022
rypdal
approved these changes
Sep 1, 2022
|
Please update the branch with the latest changes in |
|
@utpilla I think I enabled maintainer access now. |
Kielek
approved these changes
Sep 2, 2022
cijothomas
approved these changes
Sep 2, 2022
|
Forgot the changelog entry, will add it to the release PR #590. |
Oberon00
added a commit
to dynatrace-oss-contrib/opentelemetry-dotnet-contrib
that referenced
this pull request
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for another renaming proposal, but it seems really bad that we have methods that you cannot await and methods that you need to await with the same name. Also, the overload resolution between some of them could get tricky.
Note: The diff looks really strange here, please look at the two commits separately to see what's actually going on.