Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instrumentation.Process] Create src/test project files. #596

Merged
merged 15 commits into from
Aug 23, 2022
Merged

[Instrumentation.Process] Create src/test project files. #596

merged 15 commits into from
Aug 23, 2022

Conversation

Yun-Ting
Copy link
Contributor

@Yun-Ting Yun-Ting commented Aug 19, 2022 •
edited
Loading

Changes

Working towards: #447
Creating project skeleton for process instrumentation.

@Yun-Ting Yun-Ting changed the title [Instrumentation.Process] Creating src/test project files. [Instrumentation.Process] Create src/test project files. Aug 19, 2022
@Yun-Ting Yun-Ting marked this pull request as ready for review August 19, 2022 23:28
@Yun-Ting Yun-Ting requested a review from a team August 19, 2022 23:28
Kielek
Kielek reviewed Aug 22, 2022
View reviewed changes
Copy link
Contributor

@Kielek Kielek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you are missing workflow, like: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/.github/workflows/package-Instrumentation.Runtime.yml

...enTelemetry.Instrumentation.Process.Tests/OpenTelemetry.Instrumentation.Process.Tests.csproj Outdated Show resolved Hide resolved
reyang
reyang approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, consider https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/CONTRIBUTING.md#contributing-a-new-project (either in this PR or a follow up PR).

@codecov
Copy link

codecov bot commented Aug 23, 2022 •
edited
Loading

Codecov Report

Merging #596 (b5bef30) into main (dc95217) will decrease coverage by 0.16%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
- Coverage   76.56%   76.40%   -0.17%     
==========================================
  Files         168      170       +2     
  Lines        5130     5141      +11     
==========================================
  Hits         3928     3928              
- Misses       1202     1213      +11
Impacted Files Coverage Δ
...entation.Process/MeterProviderBuilderExtensions.cs 0.00% <0.00%> (ø)
...elemetry.Instrumentation.Process/ProcessMetrics.cs 0.00% <0.00%> (ø)

@Yun-Ting
Copy link
Contributor Author

LGTM, consider https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/CONTRIBUTING.md#contributing-a-new-project (either in this PR or a follow up PR).

Thanks for the link! I've added a project readme and updated the component owners doc.

@Yun-Ting
Copy link
Contributor Author

I think that you are missing workflow, like: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/.github/workflows/package-Instrumentation.Runtime.yml

Thanks for spotting it; I've added the workflow.

utpilla
utpilla reviewed Aug 23, 2022
View reviewed changes
opentelemetry-dotnet-contrib.sln
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "OpenTelemetry.Instrumentation.Process", "src\OpenTelemetry.Instrumentation.Process\OpenTelemetry.Instrumentation.Process.csproj", "{F811262D-D78A-4C4A-8A31-FFC458164BF2}"
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "OpenTelemetry.Instrumentation.Process.Tests", "test\OpenTelemetry.Instrumentation.Process.Tests\OpenTelemetry.Instrumentation.Process.Tests.csproj", "{61421ACF-5F90-491B-AFB3-14EF12CCA255}"
EndProject
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Update .sln file to add the package workflow.

@reyang
Copy link
Member

reyang commented Aug 23, 2022

image

@utpilla
Copy link
Contributor

utpilla commented Aug 23, 2022

image

This test has been failing intermittently in the past few days.

@utpilla utpilla merged commit 426f1a6 into open-telemetry:main Aug 23, 2022
@Yun-Ting Yun-Ting deleted the yunl/pInst3 branch August 23, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utpilla utpilla utpilla approved these changes

@reyang reyang reyang approved these changes

@xiang17 xiang17 xiang17 approved these changes

@Kielek Kielek Kielek approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees

@Yun-Ting Yun-Ting

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Yun-Ting @reyang @utpilla @cijothomas @Kielek @xiang17