[Instrumentation.Runtime] Two internal refactors #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
2 tasks
cijothomas
approved these changes
Aug 3, 2022
Codecov Report
@@ Coverage Diff @@
## main #559 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 167 167
Lines 5101 5100 -1
=====================================
+ Misses 5101 5100 -1
|
utpilla
reviewed
Aug 3, 2022
| { | ||
| tasks.Add(Task.Run(() => { Console.Write("Hi"); })); | ||
| } | ||
|
|
There was a problem hiding this comment.
You could probably add Asserts for pending items as well.
utpilla
reviewed
Aug 3, 2022
| } | ||
|
|
||
| Task.WaitAll(tasks.ToArray()); | ||
|
|
||
| meterProvider.ForceFlush(MaxTimeToAllowForFlush); | ||
|
|
||
| var lockContentionCountMetric = exportedItems.FirstOrDefault(i => i.Name == "process.runtime.dotnet.monitor.lock_contention.count"); |
There was a problem hiding this comment.
Unrelated to this PR, another refactoring suggestion: You could probably have these metrics names stored as const strings in RuntimeMetrics.cs and refer them here without having to hard code them.
utpilla
approved these changes
Aug 3, 2022
|
Left some suggestions which could be considered in a follow-up PR. |
samimusallam
pushed a commit
to samimusallam/opentelemetry-dotnet-contrib
that referenced
this pull request
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #.
Changes
Refactor some private code for minor non-blocker comments.
thread_pool.completed_items.count: [Instrumentation.Runtime] Add unit tests #510 (comment)const: [Instrumentation.Runtime] Enable CodeAnalysis for Runtime Instrumentation library #555 (comment)For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes