Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in the GenevaExporter PrepopulatedField handling #537

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Fix bugs in the GenevaExporter PrepopulatedField handling #537

merged 3 commits into from
Jul 28, 2022

Conversation

reyang
Copy link
Member

@reyang reyang commented Jul 28, 2022 •
edited
Loading

@reyang reyang requested a review from a team July 28, 2022 01:21
@reyang reyang mentioned this pull request Jul 28, 2022
Merged
@codecov
Copy link

codecov bot commented Jul 28, 2022 •
edited
Loading

Codecov Report

Merging #537 (e9418e1) into main (a55cbad) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #537   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        167     167           
  Lines       5097    5103    +6     
=====================================
- Misses      5097    5103    +6
Impacted Files Coverage Δ
...Telemetry.Exporter.Geneva/GenevaExporterOptions.cs 0.00% <0.00%> (ø)
...try.Exporter.Geneva/GenevaMetricExporterOptions.cs 0.00% <0.00%> (ø)

@xyq175com
Copy link
Contributor

xyq175com commented Jul 28, 2022 •
edited
Loading

@reyang
Really sorry for the issue, i thought that was the minor suggestions and no need to update..

@reyang
Copy link
Member Author

reyang commented Jul 28, 2022

@reyang Really sorry for the issue, i thought that was the minor suggestions and no need to update..

No worries 😺

@utpilla utpilla merged commit 08a1f4d into open-telemetry:main Jul 28, 2022
samimusallam pushed a commit to samimusallam/opentelemetry-dotnet-contrib that referenced this pull request Aug 9, 2022
@reyang @samimusallam
Fix bugs in the GenevaExporter PrepopulatedField handling (open-telem…
c91bcea 
…etry#537)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utpilla utpilla utpilla approved these changes

@cijothomas cijothomas Awaiting requested review from cijothomas

@CodeBlanch CodeBlanch Awaiting requested review from CodeBlanch

@mic-max mic-max Awaiting requested review from mic-max

@Yun-Ting Yun-Ting Awaiting requested review from Yun-Ting

Assignees

@cijothomas cijothomas

@mic-max mic-max

@Yun-Ting Yun-Ting

@reyang reyang

@CodeBlanch CodeBlanch

@utpilla utpilla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@reyang @xyq175com @utpilla @cijothomas @mic-max @Yun-Ting @CodeBlanch