-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.AWSLambda] Updated AWSLambda ActivitySource Name #534
[Instrumentation.AWSLambda] Updated AWSLambda ActivitySource Name #534
Conversation
Codecov Report
@@ Coverage Diff @@
## main #534 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 168 168
Lines 5128 5130 +2
=====================================
- Misses 5128 5130 +2
|
src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/Implementation/AWSLambdaUtils.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/Implementation/AWSLambdaUtils.cs
Show resolved
Hide resolved
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
d3d135b
to
212d5bb
Compare
src/OpenTelemetry.Contrib.Instrumentation.AWSLambda/CHANGELOG.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Piotr Kiełkowicz <[email protected]>
@open-telemetry/dotnet-contrib-maintainers I'm an "owner" of the component changed here, but not an approver on the repository. What can I do to get this PR merged? I would like to have this merged before requesting an release. |
The current process requires approval from maintainer/approver. I guess we want it to be changed to "the PR has to receive approval from either the project maintainer/approver, OR the owner of the component (as indicated by the |
@@ -2,6 +2,9 @@ | |||
|
|||
## Unreleased | |||
|
|||
* Updated the `ActivitySource` name to the assembly name: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the assembly name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, this should be corrected. But I hope it is consistent with the current guidelines? At least that was the assumption under which I approved it.
Fixes #484
Changes
Use the assembly name as the ActivitySource name
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes