Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.AWSLambda] Updated AWSLambda ActivitySource Name #534

Merged

Conversation

samimusallam
Copy link
Member

@samimusallam samimusallam commented Jul 26, 2022

Fixes #484

Changes

Use the assembly name as the ActivitySource name

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #

@samimusallam samimusallam requested a review from a team July 26, 2022 11:13
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #534 (2c4bf02) into main (a7ac682) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #534   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        168     168           
  Lines       5128    5130    +2     
=====================================
- Misses      5128    5130    +2     
Impacted Files Coverage Δ
...ntation.AWSLambda/Implementation/AWSLambdaUtils.cs 0.00% <0.00%> (ø)

@reyang reyang added the comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda label Jul 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2022

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 9, 2022
Co-authored-by: Piotr Kiełkowicz <[email protected]>
@github-actions github-actions bot removed the Stale label Aug 10, 2022
@Oberon00
Copy link
Member

@open-telemetry/dotnet-contrib-maintainers I'm an "owner" of the component changed here, but not an approver on the repository. What can I do to get this PR merged? I would like to have this merged before requesting an release.

@reyang
Copy link
Member

reyang commented Aug 16, 2022

@open-telemetry/dotnet-contrib-maintainers I'm an "owner" of the component changed here, but not an approver on the repository. What can I do to get this PR merged? I would like to have this merged before requesting an release.

The current process requires approval from maintainer/approver. I guess we want it to be changed to "the PR has to receive approval from either the project maintainer/approver, OR the owner of the component (as indicated by the component_owners.yml file).

@@ -2,6 +2,9 @@

## Unreleased

* Updated the `ActivitySource` name to the assembly name:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the assembly name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this should be corrected. But I hope it is consistent with the current guidelines? At least that was the assumption under which I approved it.

@utpilla utpilla merged commit ba45b7f into open-telemetry:main Aug 16, 2022
@samimusallam samimusallam deleted the update-awslambda-activitysourcename branch August 17, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Instrumentation] Standardize ActivitySource names for instrumentation projects
9 participants