[Exporter.Geneva] Add data validation for MetricExportIntervalMilliseconds #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned cijothomas, CodeBlanch, mic-max, reyang, utpilla and Yun-Ting
github-actions
bot
requested review from
cijothomas,
CodeBlanch,
mic-max,
reyang and
utpilla
Codecov Report
@@ Coverage Diff @@
## main #527 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 167 167
Lines 5099 5101 +2
=====================================
- Misses 5099 5101 +2
|
Kielek
reviewed
Jul 22, 2022
src/OpenTelemetry.Exporter.Geneva/GenevaMetricExporterOptions.cs
Outdated
Show resolved
Hide resolved
utpilla
added
the
comp:exporter.geneva
reyang
reviewed
Jul 25, 2022
test/OpenTelemetry.Exporter.Geneva.Tests/GenevaMetricExporterOptionsTests.cs
Outdated
Show resolved
Hide resolved
reyang
approved these changes
Jul 26, 2022
…n-Ting/opentelemetry-dotnet-contrib into yunl/MetricIntervalValidation
reyang
reviewed
Jul 27, 2022
test/OpenTelemetry.Exporter.Geneva.Tests/GenevaMetricExporterOptionsTests.cs
Outdated
Show resolved
Hide resolved
reyang
approved these changes
Jul 27, 2022
…ptionsTests.cs Co-authored-by: Reiley Yang <[email protected]>
utpilla
approved these changes
Jul 27, 2022
Kielek
approved these changes
Jul 27, 2022
cijothomas
approved these changes
Jul 28, 2022
samimusallam
pushed a commit
to samimusallam/opentelemetry-dotnet-contrib
that referenced
this pull request
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394.