Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ExporterGeneva]Remove ConvertToJson option #514

Merged
merged 27 commits into from
Jul 28, 2022
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
7fc318c
Fix issue- #3149
xyq175com Jul 2, 2022
1e8bb47
Merge pull request #1 from fidelity/Fix-issue-3149
xyq175com Jul 5, 2022
c560b8a
Fix issue- #3149
xyq175com Jul 2, 2022
ae0118c
Merge branch 'main' of https://github.com/fidelity/opentelemetry-dotn…
xyq175com Jul 19, 2022
7c49525
Update GenevaLogExporter.cs
xyq175com Jul 19, 2022
99243f1
Update GenevaTraceExporter.cs
xyq175com Jul 19, 2022
83b700e
Update ServerTracingInterceptor.cs
xyq175com Jul 19, 2022
f1da0b2
Update GenevaLogExporter.cs
xyq175com Jul 21, 2022
0bccfef
Update GenevaLogExporter.cs
xyq175com Jul 21, 2022
bec3cab
Update GenevaTraceExporter.cs
xyq175com Jul 21, 2022
bd56c87
Update GenevaTraceExporter.cs
xyq175com Jul 21, 2022
d40a7ba
Update GenevaLogExporter.cs
xyq175com Jul 21, 2022
a6f1b33
Merge branch 'open-telemetry:main' into fix_issue_395
xyq175com Jul 26, 2022
c0ca3b7
Update GenevaExporterOptions.cs
xyq175com Jul 26, 2022
dc57b4b
Update GenevaTraceExporter.cs
xyq175com Jul 26, 2022
1923bc0
Update GenevaLogExporter.cs
xyq175com Jul 26, 2022
bad6050
Update GenevaExporterOptions.cs
xyq175com Jul 26, 2022
f720a87
Update GenevaExporterOptions.cs
xyq175com Jul 26, 2022
dee3d27
Update GenevaExporterOptions.cs
xyq175com Jul 26, 2022
5b35e23
Update GenevaExporterOptions.cs
xyq175com Jul 26, 2022
d6a0f0c
Update GenevaExporterOptions.cs
xyq175com Jul 26, 2022
85179ed
Update GenevaExporterOptions.cs
xyq175com Jul 26, 2022
6f24239
fix_issue_395
xyq175com Jul 27, 2022
b7dad9e
Merge branch 'open-telemetry:main' into fix_issue_395
xyq175com Jul 27, 2022
7cbbbcb
Update GenevaTraceExporterTests.cs
xyq175com Jul 27, 2022
7abd65b
Update GenevaTraceExporterTests.cs
xyq175com Jul 27, 2022
9b96d60
Update GenevaTraceExporterTests.cs
xyq175com Jul 27, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/OpenTelemetry.Exporter.Geneva/GenevaLogExporter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -303,9 +303,6 @@ internal int SerializeLogRecord(LogRecord logRecord)
case double vd:
case string vs:
break;
default:
xyq175com marked this conversation as resolved.
Show resolved Hide resolved
value = this.convertToJson(value);
break;
}

utpilla marked this conversation as resolved.
Show resolved Hide resolved
cursor = AddPartAField(buffer, cursor, key, value);
Expand Down
3 changes: 0 additions & 3 deletions src/OpenTelemetry.Exporter.Geneva/GenevaTraceExporter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,6 @@ public GenevaTraceExporter(GenevaExporterOptions options)
case double vd:
case string vs:
break;
default:
value = options.ConvertToJson(value);
break;
}

cursor = AddPartAField(buffer, cursor, entry.Key, value);
Expand Down