Fix issue -propagation type is not case insensitive #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix B3 propagator is not case insensitive #3149
correct white space formatting
xyq175com
changed the title
|
xyq175com
changed the title
xyq175com
changed the title
Thank you I updated 'src/OpenTelemetry.Instrumentation.GrpcCore/CHANGELOG.md' and also tested the unit testing for this file and no failure. |
I have written "try adding a new unit test" 😉 |
pellared
reviewed
Jul 5, 2022
Co-authored-by: Robert Pająk <[email protected]>
pellared
reviewed
Jul 5, 2022
Co-authored-by: Robert Pająk <[email protected]>
pellared
approved these changes
Jul 5, 2022
utpilla
added
the
comp:instrumentation.grpccore
|
Adding @pcwiese who the component owner. Could you please review this PR? |
Codecov Report
@@ Coverage Diff @@
## main #483 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 163 163
Lines 4979 4979
=====================================
Misses 4979 4979
|
|
Looks fine to me. I don't have the power to approve directly on the issue
it seems.
…On Tue, Jul 5, 2022 at 2:07 PM Utkarsh Umesan Pillai < ***@***.***> wrote:
Adding @pcwiese <https://github.com/pcwiese> who the component owner.
Could you please review this PR?
—
Reply to this email directly, view it on GitHub
<#483 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEBE56XZU2EGVVTKVSJFP63VSSPY7ANCNFSM52U2J5LQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
utpilla
approved these changes
Jul 6, 2022
|
@xyq175com Could you please update the branch with the latest changes from main? |
|
@pcwiese I think you have the permission to approve the PR, please help on this, thank you. |
|
@xyq175com Please follow the steps mentioned here if you want a new version of this package released: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/CONTRIBUTING.md#how-to-request-for-release-of-package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the context propagation extraction case insensitive. See link:#3149
Changes
Do a case-insensitive comparison in the Grpc.Core instrumentation