Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instrumentation.Runtime] Release Runtime instrumentation version 1.0.0 #480

Closed
wants to merge 6 commits into from
Closed

[Instrumentation.Runtime] Release Runtime instrumentation version 1.0.0 #480

wants to merge 6 commits into from
+4 −0

Conversation

xiang17
Copy link
Contributor

@xiang17 xiang17 commented Jun 30, 2022

Release Runtime instrumentation version 1.0.0.

Changes

Update CHANGELOG.md.

For significant contributions please make sure you have completed the following items:

@xiang17 xiang17 requested a review from a team June 30, 2022 20:56
@pellared
Copy link
Member

Should it not first land in the OTel specification here?

@alanwest
Copy link
Member

alanwest commented Jul 7, 2022 •
edited
Loading

Should it not first land in the OTel specification here?

Related, are we banking on the assumption that the process.runtime. prefix to runtime metrics is stable? I mean I guess I would hope so 😆 as it was somewhat recent that this change was made open-telemetry/opentelemetry-specification#2112

@xiang17
Copy link
Contributor Author

xiang17 commented Jul 7, 2022 •
edited
Loading

Should it not first land in the OTel specification here?

I have been working with Reiley and also with folks from .NET runtime team including Tarek and Noah. It's a component blessed by .NET runtime owners (e.g. approvals from Noah from .NET team in #475 and Maoni in #454 regarding .NET GC). And I don't intend to make any breaking changes.

@xiang17
Copy link
Contributor Author

xiang17 commented Jul 7, 2022

Should it not first land in the OTel specification here?

Related, are we banking on the assumption that the process.runtime. prefix to runtime metrics is stable? I mean I guess I would hope so 😆 as it was somewhat recent that this change was made open-telemetry/opentelemetry-specification#2112

I'm not sure what's the requirements for the spec to become stable. From what I heard it's gonna take very long to add/modify things in the spec, which would be a big delay if I set that as a prerequisite for this component.

noahfalk
noahfalk approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@twenzel
Copy link
Contributor

twenzel commented Jul 11, 2022

LGTM

@utpilla utpilla added the comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime label Jul 11, 2022
@xiang17
Copy link
Contributor Author

xiang17 commented Jul 15, 2022

Canceled/delayed this release because of a bug in an API on .NET 6: #495.

@xiang17 xiang17 closed this Jul 15, 2022
@xiang17 xiang17 deleted the xiang17/releaseStable branch July 15, 2022 21:55
@xiang17
Copy link
Contributor Author

xiang17 commented Aug 4, 2022

This has been released in #553.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahfalk noahfalk noahfalk approved these changes

@twenzel twenzel twenzel approved these changes

Assignees

@xiang17 xiang17

Labels
comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xiang17 @pellared @alanwest @twenzel @noahfalk @utpilla @cijothomas