[Exporter.Geneva] Avoid allocation when serializing scopes #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
added
the
comp:exporter.geneva
github-actions
bot
assigned cijothomas, CodeBlanch, mic-max, reyang, utpilla and Yun-Ting
github-actions
bot
requested review from
cijothomas,
CodeBlanch,
mic-max,
reyang and
Yun-Ting
Codecov Report
@@ Coverage Diff @@
## main #433 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 163 167 +4
Lines 4983 5403 +420
======================================
- Misses 4983 5403 +420
|
utpilla
changed the title
CodeBlanch
reviewed
Jun 18, 2022
| internal ushort ScopeDepth; | ||
| internal int IndexForArrayLength; | ||
| internal int Cursor; | ||
| internal byte[] Buffer; |
There was a problem hiding this comment.
If you made this...
internal byte[] Buffer = new byte[BUFFER_SIZE];You could probably get rid of...
private static readonly ThreadLocal<byte[]> m_buffer = new ThreadLocal<byte[]>(() => null);...and just use exporterState for everything the exporter needs on a thread.
mic-max
reviewed
Jun 21, 2022
| { | ||
| state.Cursor = MessagePackSerializer.SerializeAsciiString(state.Buffer, state.Cursor, "scopes"); | ||
| state.Cursor = MessagePackSerializer.WriteArrayHeader(state.Buffer, state.Cursor, ushort.MaxValue); | ||
| state.IndexForArrayLength = state.Cursor - 2; |
There was a problem hiding this comment.
If this line is moved up one then the - 2 is not needed right?
mic-max
approved these changes
Jun 21, 2022
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #391
Changes