Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update a few metrics to be in sync of doc updates for gc.heap, gc.fragmentation.ratio, time.in.jit, process.cpu.count and assembly.count #430

Merged
merged 5 commits into from
Jun 22, 2022

Conversation

xiang17
Copy link
Contributor

@xiang17 xiang17 commented Jun 15, 2022

Update the implementation to keep up with feedbacks in #404.

Changes

  • Remove metrics for GC.GetTotalMemory(false);
  • Update GC fragmentation from "ratio" to multi-dimensional "size" for all generations
  • Update instrument type for time.in.jit to ObservableCounter
  • Remove process.cpu.count
  • Update instrument type for assembly.count to ObservableGauge

For significant contributions please make sure you have completed the following items:

- Remove metrics for `GC.GetTotalMemory(false)`;
- Update GC fragmentation from "ratio" to multi-dimensional "size" for all generations
- Update instrument type for `time.in.jit` to `ObservableCounter`
- Remove `process.cpu.count`
- Update instrument type for `assembly.count`to `ObservableGauge`
@xiang17 xiang17 requested a review from a team June 15, 2022 22:29
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #430 (95bf15e) into main (fa8c9ef) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #430   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        163     163           
  Lines       4907    4909    +2     
=====================================
- Misses      4907    4909    +2     
Impacted Files Coverage Δ
...elemetry.Instrumentation.Runtime/RuntimeMetrics.cs 0.00% <0.00%> (ø)

@reyang reyang added the comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime label Jun 17, 2022
@cijothomas cijothomas merged commit 70b1404 into open-telemetry:main Jun 22, 2022
@xiang17 xiang17 deleted the xiang17/SyncWithDoc branch January 11, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.runtime Things related to OpenTelemetry.Instrumentation.Runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants