Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hangfire OTEL] create parent context if traceparent is available #421

Merged
merged 18 commits into from
Jul 12, 2022
Merged

[Hangfire OTEL] create parent context if traceparent is available #421

merged 18 commits into from
Jul 12, 2022

Conversation

marcindruzgala
Copy link
Contributor

Changes

This change updates OpenTelemetry.Instrumentation.Hangfire package.

Currently this instrumentation package will create new activity on the server side whenever job is being executed. But this trace is not attached to the trace from which the job was enqueued. This change provides that functionality - if Activity.Current is not null.

@marcindruzgala marcindruzgala requested a review from a team June 13, 2022 13:24
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 13, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: marcindruzgala / name: Marcin Druzgala (2ce5f21)

cijothomas
cijothomas suggested changes Jun 13, 2022
View reviewed changes
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend to use the Propagators API for injecting and extracting context, instead of doing it manually.

@reyang reyang added the comp:instrumentation.hangfire Things related to OpenTelemetry.Instrumentation.Hangfire label Jun 13, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 22, 2022
@fred2u
Copy link
Contributor

fred2u commented Jun 22, 2022

Hello @cijothomas

Could you please have a look ?

Thanks.

@github-actions github-actions bot removed the Stale label Jun 23, 2022
@marcindruzgala marcindruzgala requested a review from alanwest June 24, 2022 06:27
@marcindruzgala marcindruzgala requested a review from alanwest June 28, 2022 06:56
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2022

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 6, 2022
alanwest
alanwest approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utpilla
Copy link
Contributor

utpilla commented Jul 11, 2022

@marcindruzgala Please fix the failing build.

@utpilla
Copy link
Contributor

utpilla commented Jul 11, 2022

@fred2u As the component owner for Hangfire instrumentation, could you please review this PR? It would be great if you could approve it. Thanks!

@github-actions github-actions bot removed the Stale label Jul 12, 2022
@utpilla
Copy link
Contributor

utpilla commented Jul 12, 2022

@marcindruzgala Please fix the failing build.

Please update the CHANGELOG as well.

@marcindruzgala
Copy link
Contributor Author

@marcindruzgala Please fix the failing build.

Please update the CHANGELOG as well.

Done :)

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #421 (7434a20) into main (6e84090) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #421   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        163     163           
  Lines       4977    4996   +19     
=====================================
- Misses      4977    4996   +19
Impacted Files Coverage Δ
...ation/HangfireInstrumentationJobFilterAttribute.cs 0.00% <0.00%> (ø)

@utpilla utpilla merged commit f27d824 into open-telemetry:main Jul 12, 2022
@utpilla
Copy link
Contributor

utpilla commented Jul 12, 2022

@marcindruzgala Please create a PR to update the CHANGELOG if you want a newer package with these changes to be released: https://github.com/open-telemetry/opentelemetry-dotnet-contrib/blob/main/CONTRIBUTING.md#how-to-request-for-release-of-package

@fred2u fred2u mentioned this pull request May 23, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fred2u fred2u fred2u approved these changes

@alanwest alanwest alanwest approved these changes

@cijothomas cijothomas Awaiting requested review from cijothomas

Assignees

@fred2u fred2u

Labels
comp:instrumentation.hangfire Things related to OpenTelemetry.Instrumentation.Hangfire
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marcindruzgala @fred2u @utpilla @alanwest @cijothomas @reyang