Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wcf instrumentation + example apps #38
Wcf instrumentation + example apps #38
Changes from 16 commits
914feda
ee640a3
e25beef
74d3c4c
3c67689
ffb5f08
459befb
4dbc5b1
fe0f5df
4bf55a1
47974fc
ec2d91a
ab34a65
d07c9c3
5e01cac
405c010
9c3fb42
7eb6622
63aeb50
6f6a671
da1bfc1
f34b0f6
0c42c6f
c53598e
6814bd1
abee3cc
fa2c7bd
c97f97b
aca8284
2460ad8
c81888d
7034b58
1cafa4a
cca68ad
7b28226
0d7afa3
0d1ee70
d228314
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you intentionally re-create client on each call? It is unlikely the best practice. If this is just for demo purposes, can you add a comment that this is not how the production code will look like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is more the nature of the example making a couple of calls and then closing. I'm adding this note:
Does that work for you?
@mconnew Keep me honest here. Fair to say best practice is to reuse the client?