GenevaTraceExporter bug fix to not export activities not sampled in #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned cijothomas, CodeBlanch, mic-max, reyang, utpilla and Yun-Ting
github-actions
bot
requested review from
CodeBlanch,
mic-max,
reyang,
utpilla and
Yun-Ting
reyang
reviewed
May 11, 2022
src/OpenTelemetry.Exporter.Geneva/ReentrantActivityExportProcessor.cs
Outdated
Show resolved
Hide resolved
reyang
approved these changes
May 11, 2022
…ssor.cs Co-authored-by: Reiley Yang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #352 +/- ##
==========================================
+ Coverage 24.25% 24.35% +0.10%
==========================================
Files 123 124 +1
Lines 3698 3703 +5
==========================================
+ Hits 897 902 +5
Misses 2801 2801
|
utpilla
reviewed
May 11, 2022
src/OpenTelemetry.Exporter.Geneva/ReentrantActivityExportProcessor.cs
Outdated
Show resolved
Hide resolved
utpilla
approved these changes
May 11, 2022
mic-max
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed by creating Reentrant Exporter specific to Activity.
(Will explore actually making ReEntrantExporter a public thing in the main SDK separately)