Geneva Exporter - Throw on TableNameMappings null value
#322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned cijothomas, CodeBlanch, mic-max, reyang, utpilla and Yun-Ting
github-actions
bot
requested review from
cijothomas,
CodeBlanch,
reyang,
utpilla and
Yun-Ting
reyang
approved these changes
Apr 20, 2022
|
@mic-max please address conflicts. |
cijothomas
approved these changes
Apr 21, 2022
| @@ -64,6 +65,8 @@ public GenevaLogExporter(GenevaExporterOptions options) | |||
| var tempTableMappings = new Dictionary<string, string>(options.TableNameMappings.Count, StringComparer.Ordinal); | |||
| foreach (var kv in options.TableNameMappings) | |||
| { | |||
| Guard.ThrowIfNull(kv.Value); | |||
There was a problem hiding this comment.
I would recommend including the Key name in the exception message here to help users identify which value is null.
There was a problem hiding this comment.
Would it be better to do this validation in the GenevaExporterOptions class, like how it's done for PrepopulatedFields?
|
What should be done when a null key exists in the |
Codecov Report
@@ Coverage Diff @@
## main #322 +/- ##
==========================================
+ Coverage 24.09% 24.25% +0.16%
==========================================
Files 123 123
Lines 3690 3698 +8
==========================================
+ Hits 889 897 +8
Misses 2801 2801
|
cijothomas
reviewed
Apr 28, 2022
cijothomas
reviewed
May 6, 2022
cijothomas
approved these changes
May 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw exception when null value is used in
TableNameMappingsfor Geneva Exporter Options class.Includes unit test.