Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources.AWS] Move string literals to AWS Semantic Conventions class #2363

Conversation

ppittle
Copy link
Member

@ppittle ppittle commented Dec 5, 2024

Changes

Move string literals to be constants in the AWS Semantic Conventions class. This is in preparation of a larger overhaul in how the AWS libraries will handle Semantic Conventions.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@ppittle ppittle requested a review from a team as a code owner December 5, 2024 21:55
@github-actions github-actions bot requested a review from srprash December 5, 2024 21:56
@github-actions github-actions bot added the comp:resources.aws Things related to OpenTelemetry.Resources.AWS label Dec 5, 2024
@ppittle ppittle force-pushed the move-string-literals-to-aws-semantic-convention branch from 0d97331 to 5a21cd2 Compare December 5, 2024 22:07
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.16%. Comparing base (71655ce) to head (eae79ce).
Report is 623 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2363      +/-   ##
==========================================
+ Coverage   73.91%   79.16%   +5.25%     
==========================================
  Files         267       12     -255     
  Lines        9615      288    -9327     
==========================================
- Hits         7107      228    -6879     
+ Misses       2508       60    -2448     
Flag Coverage Δ
unittests-Resources.AWS 79.16% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/OpenTelemetry.Resources.AWS/AWSEBSDetector.cs 92.59% <100.00%> (ø)
src/OpenTelemetry.Resources.AWS/AWSEC2Detector.cs 74.28% <100.00%> (ø)
src/OpenTelemetry.Resources.AWS/AWSECSDetector.cs 87.87% <100.00%> (ø)
src/OpenTelemetry.Resources.AWS/AWSEKSDetector.cs 64.28% <100.00%> (ø)

... and 271 files with indirect coverage changes

@ppittle ppittle force-pushed the move-string-literals-to-aws-semantic-convention branch from 5a21cd2 to da78f8c Compare December 6, 2024 04:16
@Kielek Kielek changed the title Move string literals to AWS Semantic Conventions class [Resources.AWS] Move string literals to AWS Semantic Conventions class Dec 6, 2024
@Kielek Kielek merged commit 57d4769 into open-telemetry:main Dec 6, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.aws Things related to OpenTelemetry.Resources.AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants