Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo/OneCollector] Prepare to .NET9 #2341

Merged
merged 18 commits into from
Nov 22, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Nov 21, 2024

Changes

Follow up #2251

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team as a code owner November 21, 2024 08:52
@github-actions github-actions bot requested a review from CodeBlanch November 21, 2024 08:52
@github-actions github-actions bot added infra Infra work - CI/CD, code coverage, linters comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector perf Performance related labels Nov 21, 2024
@Kielek Kielek force-pushed the net9prep-onecollector branch from 18c69f8 to f332a3a Compare November 21, 2024 08:58
@github-actions github-actions bot removed the infra Infra work - CI/CD, code coverage, linters label Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 98.14815% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.50%. Comparing base (71655ce) to head (539696a).
Report is 612 commits behind head on main.

Files with missing lines Patch % Lines
...ternal/Serialization/CommonSchemaJsonSerializer.cs 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2341       +/-   ##
===========================================
+ Coverage   73.91%   94.50%   +20.58%     
===========================================
  Files         267       28      -239     
  Lines        9615     1183     -8432     
===========================================
- Hits         7107     1118     -5989     
+ Misses       2508       65     -2443     
Flag Coverage Δ
unittests-Exporter.OneCollector 94.50% <98.14%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
....Exporter.OneCollector/Internal/CallbackManager.cs 96.00% <100.00%> (+0.16%) ⬆️
...er.OneCollector/Internal/ConnectionStringParser.cs 100.00% <100.00%> (ø)
...ry.Exporter.OneCollector/Internal/EventFullName.cs 100.00% <100.00%> (ø)
...Exporter.OneCollector/Internal/EventNameManager.cs 100.00% <100.00%> (+2.85%) ⬆️
...rialization/CommonSchemaJsonSerializationHelper.cs 100.00% <100.00%> (ø)
...erialization/CommonSchemaJsonSerializationState.cs 97.36% <100.00%> (+0.10%) ⬆️
...rialization/LogRecordCommonSchemaJsonSerializer.cs 99.21% <100.00%> (+0.04%) ⬆️
...tor/Internal/Sinks/WriteDirectlyToTransportSink.cs 97.33% <100.00%> (+6.19%) ⬆️
...ector/Internal/Transports/HttpJsonPostTransport.cs 95.62% <100.00%> (+0.20%) ⬆️
...neCollector/Logs/OneCollectorLogExporterOptions.cs 100.00% <100.00%> (+20.00%) ⬆️
... and 2 more

... and 255 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot requested a review from CodeBlanch November 22, 2024 18:30
@Kielek Kielek merged commit 739337f into open-telemetry:main Nov 22, 2024
60 of 61 checks passed
@Kielek Kielek deleted the net9prep-onecollector branch November 22, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector perf Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants