Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrumentation.StackExchangeRedis] Fix tests on .NET9 #2327

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Nov 15, 2024

Fixes #2324

Changes

[Instrumentation.StackExchangeRedis] Fix tests on .NET9

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team as a code owner November 15, 2024 13:03
@Kielek
Copy link
Contributor Author

Kielek commented Nov 15, 2024

@xiang17, FYI

@github-actions github-actions bot added the comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.21%. Comparing base (71655ce) to head (1d08c69).
Report is 599 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2327      +/-   ##
==========================================
- Coverage   73.91%   71.21%   -2.70%     
==========================================
  Files         267        5     -262     
  Lines        9615      271    -9344     
==========================================
- Hits         7107      193    -6914     
+ Misses       2508       78    -2430     
Flag Coverage Δ
unittests-Instrumentation.StackExchangeRedis 71.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 264 files with indirect coverage changes

@Kielek Kielek merged commit cf9384a into open-telemetry:main Nov 15, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instrumentaiton.StackExchangeRedis - support .NET9
3 participants