-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.SqlClient] Implements database metric db.client.operation.duration
#2309
[Instrumentation.SqlClient] Implements database metric db.client.operation.duration
#2309
Conversation
src/OpenTelemetry.Instrumentation.SqlClient/SqlClientMetricsInstrumentationOptions.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2309 +/- ##
===========================================
+ Coverage 73.91% 89.02% +15.10%
===========================================
Files 267 9 -258
Lines 9615 410 -9205
===========================================
- Hits 7107 365 -6742
+ Misses 2508 45 -2463
Flags with carried forward coverage won't be shown. Click here to find out more.
|
src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlClientDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlClientDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlClientDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Instrumentation.SqlClient/Implementation/SqlClientDiagnosticListener.cs
Show resolved
Hide resolved
src/OpenTelemetry.Instrumentation.SqlClient/.publicApi/PublicAPI.Unshipped.txt
Outdated
Show resolved
Hide resolved
I merged this PR prematurely without a changelog. Spoke with @matt-hensley, he's working on making metrics work for .NET Framework in a follow on PR. Changelog will be updated there. |
Fixes #
Design discussion issue #
Changes
Implements proposed
db.client.operation.duration
metric for SqlClient with required attributes.Only implemented against .NET 6+ for now.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes