[repo/Http] Prepare to .NET9 #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:instrumentation.http
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2298 +/- ##
==========================================
+ Coverage 73.91% 74.11% +0.20%
==========================================
Files 267 11 -256
Lines 9615 823 -8792
==========================================
- Hits 7107 610 -6497
+ Misses 2508 213 -2295
Flags with carried forward coverage won't be shown. Click here to find out more.
|
CodeBlanch
reviewed
Nov 5, 2024
src/OpenTelemetry.Instrumentation.Http/HttpClientInstrumentation.cs
Outdated
Show resolved
Hide resolved
CodeBlanch
reviewed
Nov 5, 2024
| FieldInfo servicePointTableField = typeof(ServicePointManager).GetField("s_ServicePointTable", BindingFlags.Static | BindingFlags.NonPublic) | ||
| ?? throw new InvalidOperationException("Unable to access the ServicePointTable field"); | ||
| var servicePointTableField = typeof(ServicePointManager).GetField("s_ServicePointTable", BindingFlags.Static | BindingFlags.NonPublic) | ||
| ?? throw new InvalidOperationException("Unable to access the ServicePointTable field"); |
There was a problem hiding this comment.
Did dotnet format add this blank space? Interesting 🤔
There was a problem hiding this comment.
For sure, it is not complaining :)
It seems that it is alliggned to typeof from the previous line.
…on.cs Co-authored-by: Mikel Blanchard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follow up #2251
Merge requirement checklist
[ ] Unit tests added/updated[ ] AppropriateCHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)