Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo/Quartz] Prepare to .NET9 #2293

Merged
merged 6 commits into from
Nov 4, 2024
Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Nov 4, 2024

Changes

Follow up #2251

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team as a code owner November 4, 2024 13:57
@github-actions github-actions bot requested a review from maldago November 4, 2024 13:57
@github-actions github-actions bot added the comp:instrumentation.quartz Things related to OpenTelemetry.Instrumentation.Quartz label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (71655ce) to head (8062906).
Report is 579 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2293      +/-   ##
==========================================
+ Coverage   73.91%   78.76%   +4.84%     
==========================================
  Files         267        5     -262     
  Lines        9615      113    -9502     
==========================================
- Hits         7107       89    -7018     
+ Misses       2508       24    -2484     
Flag Coverage Δ
unittests-Instrumentation.Quartz 78.76% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
....Quartz/Implementation/QuartzDiagnosticListener.cs 82.60% <100.00%> (-4.49%) ⬇️

... and 263 files with indirect coverage changes

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kielek Kielek merged commit a1edda6 into open-telemetry:main Nov 4, 2024
55 checks passed
@Kielek Kielek deleted the net9prep-quartz branch November 4, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.quartz Things related to OpenTelemetry.Instrumentation.Quartz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants