Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo/ElasticsearchClient] Prepare to .NET9 #2292

Merged
merged 9 commits into from
Nov 4, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Nov 4, 2024

Changes

Follow up #2251

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team as a code owner November 4, 2024 13:07
@github-actions github-actions bot requested a review from ejsmith November 4, 2024 13:07
@github-actions github-actions bot added the comp:instrumentation.elasticsearchclient Things related to OpenTelemetry.Instrumentation.ElasticsearchClient label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.12%. Comparing base (71655ce) to head (2640277).
Report is 580 commits behind head on main.

Files with missing lines Patch % Lines
.../ElasticsearchRequestPipelineDiagnosticListener.cs 50.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2292      +/-   ##
==========================================
+ Coverage   73.91%   80.12%   +6.20%     
==========================================
  Files         267        5     -262     
  Lines        9615      161    -9454     
==========================================
- Hits         7107      129    -6978     
+ Misses       2508       32    -2476     
Flag Coverage Δ
unittests-Instrumentation.ElasticsearchClient 80.12% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../ElasticsearchRequestPipelineDiagnosticListener.cs 83.73% <50.00%> (+1.53%) ⬆️

... and 263 files with indirect coverage changes

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kielek Kielek merged commit d7a8fc2 into open-telemetry:main Nov 4, 2024
55 checks passed
@Kielek Kielek deleted the net9prep-elastic branch November 4, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.elasticsearchclient Things related to OpenTelemetry.Instrumentation.ElasticsearchClient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants