Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo/AwsInstrumentations] Prepare to .NET9 #2272

Merged
merged 33 commits into from
Oct 31, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Oct 30, 2024

Changes

Follow up #2251

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team as a code owner October 30, 2024 08:07
@github-actions github-actions bot added the comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS label Oct 30, 2024
@github-actions github-actions bot added the comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda label Oct 30, 2024
@Kielek Kielek force-pushed the net9prep-awsinstr branch from a516c43 to a2950b0 Compare October 30, 2024 08:08
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 90.19608% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.07%. Comparing base (71655ce) to head (b24b1da).
Report is 569 commits behind head on main.

Files with missing lines Patch % Lines
...emetry.Instrumentation.AWS/Implementation/Utils.cs 70.00% 3 Missing ⚠️
...on.AWS/Implementation/AWSTracingPipelineHandler.cs 66.66% 1 Missing ⚠️
...ntation.AWS/Implementation/Tracing/AWSTraceSpan.cs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2272      +/-   ##
==========================================
+ Coverage   73.91%   83.07%   +9.16%     
==========================================
  Files         267       25     -242     
  Lines        9615      585    -9030     
==========================================
- Hits         7107      486    -6621     
+ Misses       2508       99    -2409     
Flag Coverage Δ
unittests-Instrumentation.AWS 83.07% <90.19%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rumentation.AWS/Implementation/AWSServiceHelper.cs 98.64% <100.00%> (-1.36%) ⬇️
...ntation.AWS/Implementation/Metrics/AWSHistogram.cs 87.50% <100.00%> (ø)
...ion.AWS/Implementation/Metrics/AWSMeterProvider.cs 100.00% <100.00%> (ø)
....AWS/Implementation/Metrics/AWSMonotonicCounter.cs 87.50% <100.00%> (ø)
...ion.AWS/Implementation/Metrics/AWSUpDownCounter.cs 93.75% <100.00%> (ø)
...tion.AWS/Implementation/SnsRequestContextHelper.cs 90.90% <100.00%> (-4.10%) ⬇️
...tion.AWS/Implementation/SqsRequestContextHelper.cs 81.81% <100.00%> (-13.19%) ⬇️
...umentation.AWS/Implementation/Tracing/AWSTracer.cs 57.69% <100.00%> (ø)
...on.AWS/Implementation/Tracing/AWSTracerProvider.cs 100.00% <100.00%> (ø)
...on.AWS/Implementation/AWSTracingPipelineHandler.cs 81.57% <66.66%> (-6.18%) ⬇️
... and 2 more

... and 262 files with indirect coverage changes

Copy link
Member

@Oberon00 Oberon00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving just for the Lambda part

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

return originalString;
return string.IsNullOrEmpty(originalString)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Do we have to make this change? The previous version was more readable to me.

@Kielek Kielek merged commit 32d6db5 into open-telemetry:main Oct 31, 2024
56 checks passed
@Kielek Kielek deleted the net9prep-awsinstr branch October 31, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS comp:instrumentation.awslambda Things related to OpenTelemetry.Instrumentation.AWSLambda
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants