Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo/AWS.Sampler] Prepare to .NET9 #2266

Merged
merged 9 commits into from
Oct 30, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Oct 29, 2024

Changes

Follow up #2251

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@Kielek Kielek requested a review from a team as a code owner October 29, 2024 05:51
@github-actions github-actions bot requested review from ppittle and srprash October 29, 2024 05:52
@github-actions github-actions bot added the comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS label Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 82.45614% with 10 lines in your changes missing coverage. Please review.

Project coverage is 73.00%. Comparing base (71655ce) to head (2756105).
Report is 561 commits behind head on main.

Files with missing lines Patch % Lines
.../OpenTelemetry.Sampler.AWS/AWSXRayRemoteSampler.cs 45.45% 6 Missing ⚠️
src/OpenTelemetry.Sampler.AWS/FallbackSampler.cs 0.00% 2 Missing ⚠️
src/OpenTelemetry.Sampler.AWS/SamplingRule.cs 0.00% 1 Missing ⚠️
src/OpenTelemetry.Sampler.AWS/SystemClock.cs 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2266      +/-   ##
==========================================
- Coverage   73.91%   73.00%   -0.92%     
==========================================
  Files         267      359      +92     
  Lines        9615    13747    +4132     
==========================================
+ Hits         7107    10036    +2929     
- Misses       2508     3711    +1203     
Flag Coverage Δ
unittests-Contrib.Shared.Tests 77.13% <ø> (?)
unittests-Exporter.Geneva 62.34% <ø> (?)
unittests-Exporter.InfluxDB 95.14% <ø> (?)
unittests-Exporter.Instana 74.86% <ø> (?)
unittests-Exporter.OneCollector 94.34% <ø> (?)
unittests-Exporter.Stackdriver 79.26% <ø> (?)
unittests-Extensions 88.63% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 85.95% <ø> (?)
unittests-Instrumentation.AspNet 76.73% <ø> (?)
unittests-Instrumentation.AspNetCore 70.06% <ø> (?)
unittests-Instrumentation.ConfluentKafka 14.12% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 79.87% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 57.06% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 73.57% <ø> (?)
unittests-Instrumentation.Owin 85.97% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.94% <ø> (?)
unittests-Instrumentation.Runtime 97.53% <ø> (?)
unittests-Instrumentation.SqlClient 91.36% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 71.21% <ø> (?)
unittests-Instrumentation.Wcf 78.34% <ø> (?)
unittests-PersistentStorage 65.88% <ø> (?)
unittests-Resources.AWS 79.16% <ø> (?)
unittests-Resources.Azure 84.56% <ø> (?)
unittests-Resources.Container 67.34% <ø> (?)
unittests-Resources.Gcp 71.15% <ø> (?)
unittests-Resources.Host 73.91% <ø> (?)
unittests-Resources.OperatingSystem 76.98% <ø> (?)
unittests-Resources.Process 100.00% <ø> (?)
unittests-Resources.ProcessRuntime 78.26% <ø> (?)
unittests-Sampler.AWS 88.23% <82.45%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../OpenTelemetry.Sampler.AWS/AWSXRaySamplerClient.cs 97.18% <100.00%> (+5.65%) ⬆️
src/OpenTelemetry.Sampler.AWS/Matcher.cs 97.82% <100.00%> (-0.10%) ⬇️
src/OpenTelemetry.Sampler.AWS/RateLimiter.cs 100.00% <100.00%> (ø)
src/OpenTelemetry.Sampler.AWS/RulesCache.cs 83.54% <100.00%> (+1.72%) ⬆️
...c/OpenTelemetry.Sampler.AWS/SamplingRuleApplier.cs 99.26% <100.00%> (+0.70%) ⬆️
src/OpenTelemetry.Sampler.AWS/SamplingRule.cs 90.47% <0.00%> (ø)
src/OpenTelemetry.Sampler.AWS/SystemClock.cs 63.63% <50.00%> (ø)
src/OpenTelemetry.Sampler.AWS/FallbackSampler.cs 66.66% <0.00%> (+11.11%) ⬆️
.../OpenTelemetry.Sampler.AWS/AWSXRayRemoteSampler.cs 53.42% <45.45%> (+2.70%) ⬆️

... and 369 files with indirect coverage changes

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kielek Kielek merged commit 3fc1415 into open-telemetry:main Oct 30, 2024
128 of 129 checks passed
@Kielek Kielek deleted the net9prep-awssampler branch October 30, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants