Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[geneva] Add support for sending metrics in OTLP format over UDS #2261

Merged
merged 14 commits into from
Oct 30, 2024

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Oct 28, 2024

Changes

  • Adds support for sending metrics in OTLP format over Unix domain sockets.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@CodeBlanch CodeBlanch requested a review from a team as a code owner October 28, 2024 18:42
@github-actions github-actions bot added comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva perf Performance related labels Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 56.85%. Comparing base (71655ce) to head (311c412).
Report is 566 commits behind head on main.

Files with missing lines Patch % Lines
...ry.Exporter.Geneva/Metrics/GenevaMetricExporter.cs 72.22% 5 Missing ⚠️
...s/Transport/MetricUnixDomainSocketDataTransport.cs 0.00% 2 Missing ⚠️
...Metrics/OtlpProtobuf/OtlpProtobufMetricExporter.cs 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2261       +/-   ##
===========================================
- Coverage   73.91%   56.85%   -17.07%     
===========================================
  Files         267       45      -222     
  Lines        9615     4005     -5610     
===========================================
- Hits         7107     2277     -4830     
+ Misses       2508     1728      -780     
Flag Coverage Δ
unittests-Exporter.Geneva 56.85% <80.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...eva/Metrics/OtlpProtobuf/OtlpProtobufSerializer.cs 90.00% <100.00%> (ø)
...Metrics/OtlpProtobuf/OtlpProtobufMetricExporter.cs 82.60% <90.00%> (ø)
...s/Transport/MetricUnixDomainSocketDataTransport.cs 0.00% <0.00%> (ø)
...ry.Exporter.Geneva/Metrics/GenevaMetricExporter.cs 87.75% <72.22%> (+21.08%) ⬆️

... and 244 files with indirect coverage changes

@cijothomas
Copy link
Member

Something to consider in future: open-telemetry/opentelemetry-rust-contrib#104 (comment)

With UnixSockets, we are doing one call per MetricPoint (same for etw/user-events too). This may need revisit, especially for sockets.

Copy link
Contributor

@rajkumar-rangaraj rajkumar-rangaraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch merged commit 0351a0b into open-telemetry:main Oct 30, 2024
56 checks passed
@CodeBlanch CodeBlanch deleted the geneva-uds-otlp branch October 30, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva perf Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants