-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[geneva] Add support for sending metrics in OTLP format over UDS #2261
[geneva] Add support for sending metrics in OTLP format over UDS #2261
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2261 +/- ##
===========================================
- Coverage 73.91% 56.85% -17.07%
===========================================
Files 267 45 -222
Lines 9615 4005 -5610
===========================================
- Hits 7107 2277 -4830
+ Misses 2508 1728 -780
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Something to consider in future: open-telemetry/opentelemetry-rust-contrib#104 (comment) With UnixSockets, we are doing one call per MetricPoint (same for etw/user-events too). This may need revisit, especially for sockets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Cijo Thomas <[email protected]>
Changes
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes