Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.Geneva] benchmarks nullable #2254

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Oct 28, 2024

Towards #894

Changes

[Exporter.Geneva] benchmarks nullable
With fully nullable repository, it will be easier to accomplish #2251. Unneeded #nullable enable are treated as warnings -> errors in .NET9.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • [ ] Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@github-actions github-actions bot added comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva perf Performance related labels Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.34%. Comparing base (71655ce) to head (6f195f9).
Report is 552 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2254       +/-   ##
===========================================
- Coverage   73.91%   62.34%   -11.58%     
===========================================
  Files         267       45      -222     
  Lines        9615     3986     -5629     
===========================================
- Hits         7107     2485     -4622     
+ Misses       2508     1501     -1007     
Flag Coverage Δ
unittests-Exporter.Geneva 62.34% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...Metrics/OtlpProtobuf/OtlpProtobufMetricExporter.cs 82.60% <100.00%> (ø)

... and 248 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review October 28, 2024 12:51
@Kielek Kielek requested a review from a team as a code owner October 28, 2024 12:51
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot requested a review from CodeBlanch October 28, 2024 18:03
@Kielek Kielek merged commit c09a331 into open-telemetry:main Oct 28, 2024
56 checks passed
@Kielek Kielek deleted the geneva-benchmarks-nullable branch October 28, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva perf Performance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants