-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sqlclient] Enable collecting server.* attributes by default #2249
[sqlclient] Enable collecting server.* attributes by default #2249
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2249 +/- ##
===========================================
+ Coverage 73.91% 91.36% +17.44%
===========================================
Files 267 8 -259
Lines 9615 301 -9314
===========================================
- Hits 7107 275 -6832
+ Misses 2508 26 -2482
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I was a bit surprised there were no tests I needed to update. I do have some work in flight for refactoring and expanding the test coverage, so I don't want to address that in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #2235
Confirmed with @lmolkova and @trask in the DB conventions SIG that the
server.address
/server.port
attributes need to be collected by default.