-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.Wcf] Add .NET6 as target framework #2243
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2243 +/- ##
==========================================
+ Coverage 73.91% 78.34% +4.43%
==========================================
Files 267 29 -238
Lines 9615 702 -8913
==========================================
- Hits 7107 550 -6557
+ Misses 2508 152 -2356
Flags with carried forward coverage won't be shown. Click here to find out more.
|
src/OpenTelemetry.Instrumentation.Wcf/OpenTelemetry.Instrumentation.Wcf.csproj
Show resolved
Hide resolved
src/OpenTelemetry.Instrumentation.Wcf/Implementation/HttpRequestMessagePropertyWrapper.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Instrumentation.Wcf/Implementation/RequestTelemetryStateTracker.cs
Outdated
Show resolved
Hide resolved
|
||
try | ||
{ | ||
ExecutionContext.Run(ExecutionContext.Capture(), executeInChildContext, null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the part I'm not sure about. I'm going to try and find an expert on the .NET runtime team to ask about what to do here. I'll post back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking for any advice you can give : )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't nailed it down yet but I approved the PR. We're adding a throw here for null
EC but ExecutionContext.Run
should be throwing today in that case anyway and no user has complained about it AFAIK.
We can circle back to it if any new info comes to light.
Co-authored-by: Mikel Blanchard <[email protected]>
Co-authored-by: Mikel Blanchard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes scenario when you referencing Instrumentation.Wcf package from .NET6+ with enabled NuGet Audit like for .NET9.
Without changes it was leading to the issues:
Workaround:
Manual referencing safe version of System.Drawing.Common, but it is not user friendly.
Changes
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)