Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extensions.aws & sampler.aws] STJ tweaks #2209

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

CodeBlanch
Copy link
Member

[This PR effectively reverts #2199]

Changes

  • Remove STJ from OpenTelemetry.Extensions.AWS completely as it isn't used by any of the code.
  • Put STJ back to 6.0.10 for net462 and netstandard2.0 targets in OpenTelemetry.Sampler.AWS because it relies on some of its behaviors (being able to deserialize to classes which do not have a public parameterless ctor).

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team as a code owner October 11, 2024 20:52
@github-actions github-actions bot added comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS labels Oct 11, 2024
@github-actions github-actions bot requested review from ppittle and srprash October 11, 2024 20:52
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.75%. Comparing base (71655ce) to head (c0ed331).
Report is 532 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2209       +/-   ##
===========================================
+ Coverage   73.91%   85.75%   +11.83%     
===========================================
  Files         267       15      -252     
  Lines        9615      393     -9222     
===========================================
- Hits         7107      337     -6770     
+ Misses       2508       56     -2452     
Flag Coverage Δ
unittests-Extensions 88.63% <ø> (?)
unittests-Extensions.AWS 83.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 268 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 8286d8d into open-telemetry:main Oct 11, 2024
59 checks passed
@CodeBlanch CodeBlanch deleted the aws-stj-tweaks branch October 11, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS comp:sampler.aws Things related to OpenTelemetry.Samplers.AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants