Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onecollector-1.9.2] Patch extension data fix #2208

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Oct 11, 2024

[Note: This PR is going into the main-onecollector-1.9.2 branch which was created off of the Exporter.OneCollector-1.9.2 tag.]

Changes

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team as a code owner October 11, 2024 17:25
@github-actions github-actions bot requested a review from reyang October 11, 2024 17:26
@github-actions github-actions bot added the comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector label Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main-onecollector-1.9.2@4c34ab4). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##             main-onecollector-1.9.2    #2208   +/-   ##
==========================================================
  Coverage                           ?   93.24%           
==========================================================
  Files                              ?       27           
  Lines                              ?     1037           
  Branches                           ?        0           
==========================================================
  Hits                               ?      967           
  Misses                             ?       70           
  Partials                           ?        0           
Flag Coverage Δ
unittests-Exporter.OneCollector 93.24% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...erialization/CommonSchemaJsonSerializationState.cs 97.36% <100.00%> (ø)
...ternal/Serialization/CommonSchemaJsonSerializer.cs 90.16% <100.00%> (ø)

@CodeBlanch CodeBlanch merged commit 7146c0a into open-telemetry:main-onecollector-1.9.2 Oct 11, 2024
67 of 69 checks passed
@CodeBlanch CodeBlanch deleted the onecollector-patch-extension-data-fix branch October 11, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants