[Sampler.AWS] Wrapped root sampler with ParentBasedSampler

[AsakerMohd]

Fixes #
Design discussion issue #

Changes

The current implementation of the X-Ray sampler has 2 levels: The X-Ray Sampler itself which is made up two different samplers for X-Ray purposes. Those two different samplers are wrapped by parentBasedSampler so that the children inherit the parent sampling decision. However, on the CloudWatch console, we are adding the children sampling decision into the stats section. This means: if we have 1 parent and 9 children, the CW console will show that 10 spans are sampled which isn't correct. It should show only 1 span being sampled. This PR moves the ParentBasedSampler wrapper to be on the root level of the X-Ray sampler. This means that the builder doesn't return AWSXrayRemoteSampler anymore but returns ParentBasedSampler(new AWSXrayRemoteSampler). This keeps the same parentBasedSampling logic but is instead on the root level thus skipping the stat aggregation for the children.

Merge requirement checklist

• CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
• Unit tests added/updated
• Appropriate CHANGELOG.md files updated for non-trivial changes
• Changes in public API reviewed (if applicable)

[vastin]

LGTM

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.25%. Comparing base (71655ce) to head (56e5f14).
Report is 606 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2188       +/-   ##
===========================================
+ Coverage   73.91%   88.25%   +14.34%     
===========================================
  Files         267       20      -247     
  Lines        9615      562     -9053     
===========================================
- Hits         7107      496     -6611     
+ Misses       2508       66     -2442     

Flag	Coverage Δ
unittests-Sampler.AWS	88.25% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...lemetry.Sampler.AWS/AWSXRayRemoteSamplerBuilder.cs	83.33% <100.00%> (+0.98%)	⬆️
src/OpenTelemetry.Sampler.AWS/FallbackSampler.cs	66.66% <100.00%> (+11.11%)	⬆️
...c/OpenTelemetry.Sampler.AWS/SamplingRuleApplier.cs	99.26% <100.00%> (+0.70%)	⬆️

... and 261 files with indirect coverage changes

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

[Kielek]

@ppittle, do you want to merge this?

@AsakerMohd, I think that having CHANGELOG entry is good idea here.

[AsakerMohd]

@ppittle, do you want to merge this?

@AsakerMohd, I think that having CHANGELOG entry is good idea here.

Yeah let me do that.

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

[ppittle]

@AsakerMohd - LGTM - thanks for the changes!

[Kielek]

Approving ane mergin based on @ppittle comment.