Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resources.Azure] Replace .NET 6 target with .NET 8 #2165

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

joegoldman2
Copy link
Contributor

@joegoldman2 joegoldman2 commented Oct 4, 2024

Changes

Replace .NET 6 target, which will be very soon out of support, with .NET 8.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@joegoldman2 joegoldman2 requested a review from a team as a code owner October 4, 2024 09:09
@github-actions github-actions bot added the comp:resources.azure Things related to OpenTelemetry.Resources.Azure label Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.89%. Comparing base (71655ce) to head (72fed8d).
Report is 496 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2165      +/-   ##
==========================================
+ Coverage   73.91%   83.89%   +9.97%     
==========================================
  Files         267        6     -261     
  Lines        9615      149    -9466     
==========================================
- Hits         7107      125    -6982     
+ Misses       2508       24    -2484     
Flag Coverage Δ
unittests-Resources.Azure 83.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 270 files with indirect coverage changes

@joegoldman2 joegoldman2 changed the title [Resources.Azure] Remove .NET 6 target and add .NET Standard 2.0 [Resources.Azure] Replace .NET 6 target with .NET 8 Oct 4, 2024
@Kielek Kielek merged commit 370ca66 into open-telemetry:main Oct 4, 2024
59 checks passed
@joegoldman2 joegoldman2 deleted the resourcesazure-tfm branch October 4, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:resources.azure Things related to OpenTelemetry.Resources.Azure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants